Comments on: Reasons to write bad code !! http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/ Development, Microsoft, Open Source, Standards, ....,.....,...... Cooking, Travelling and blablabla Wed, 07 Jan 2009 01:59:20 +0000 http://wordpress.org/?v=2.5.1 By: Jawed’s Blog » Quality Driven Development http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-17 Jawed’s Blog » Quality Driven Development Tue, 15 Jul 2008 18:07:56 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-17 [...] was reading an article about Reasons to write bad code !!, the author was sharing his experience about having problem with some bad code, written by his [...] [...] was reading an article about Reasons to write bad code !!, the author was sharing his experience about having problem with some bad code, written by his [...]

]]> By: Abhishek http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-16 Abhishek Tue, 15 Jul 2008 16:59:08 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-16 @Jawed, Indeed a very valid point. I had this question in my mind when I come to know about the reason for this unprofessional behavior. As you said, due to the short development time and to earn maximum benefits in immediate future, management tend to avoid standards. Due to tight schedule our team was not following peer review. I found this issue because I had to modify the aforementioned script. Having said that, It does not justify me or anybody for that matter, as an individual to deliberately compromise with the profession due to stress and pressure. In my knowledge, I will never write a bad code or design a bad algorithm which would be a pain to maintain. Generating Logic is a creative process. However, I agree that in many cases due to several factors at managerial or enterprise level, quality is compromised to certain extent. The case I mentioned does not fit in this criteria though as it deals with an individual. Finally, as others mentioned, if you are not happy in your job then talk about it to the manager or start looking elsewhere. @Jawed, Indeed a very valid point. I had this question in my mind when I come to know about the reason for this unprofessional behavior. As you said, due to the short development time and to earn maximum benefits in immediate future, management tend to avoid standards. Due to tight schedule our team was not following peer review. I found this issue because I had to modify the aforementioned script.
Having said that, It does not justify me or anybody for that matter, as an individual to deliberately compromise with the profession due to stress and pressure. In my knowledge, I will never write a bad code or design a bad algorithm which would be a pain to maintain. Generating Logic is a creative process. However, I agree that in many cases due to several factors at managerial or enterprise level, quality is compromised to certain extent. The case I mentioned does not fit in this criteria though as it deals with an individual.
Finally, as others mentioned, if you are not happy in your job then talk about it to the manager or start looking elsewhere.

]]> By: Jawed Ali http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-15 Jawed Ali Tue, 15 Jul 2008 16:17:09 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-15 Your point to some extent arguable like Tristan mentioned but you can not completely deny the fact that many coders (people who don't know how to write good code), don't have exposure to write good code and practices. <b>To argue about code is bad, you must know whats good</b>. Also it's a common practice to criticize what his successor has developed. No body try to avenge the company but the company is alone responsible for the mess. They are not following review and refactoring process, what the project manager or team lead was doing when that guy is wring bad code, why nobody noticed that found out reasons behind it. Stress and tight schedule always leave their effects in long run. Management always forgets the long term consequences to gain short term profit. Keep in mind that <b>"Quality is a management driven activity/process."</b> Your point to some extent arguable like Tristan mentioned but you can not completely deny the fact that many coders (people who don’t know how to write good code), don’t have exposure to write good code and practices. To argue about code is bad, you must know whats good. Also it’s a common practice to criticize what his successor has developed.

No body try to avenge the company but the company is alone responsible for the mess. They are not following review and refactoring process, what the project manager or team lead was doing when that guy is wring bad code, why nobody noticed that found out reasons behind it. Stress and tight schedule always leave their effects in long run. Management always forgets the long term consequences to gain short term profit.

Keep in mind that “Quality is a management driven activity/process.”

]]> By: Sergej Andrejev http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-13 Sergej Andrejev Sun, 13 Jul 2008 18:27:25 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-13 A very good point. Currently I'm just like you and hope to keep the shape for a long time, but I'm afraid. B looking at the bad code deadlines overwork can break me really soon. Sadly :( Anyway I don't want to leave, because I thing they will have hard time without me, so I decided that I will only leave if I get a great offer. A very good point. Currently I’m just like you and hope to keep the shape for a long time, but I’m afraid. B looking at the bad code deadlines overwork can break me really soon. Sadly :(
Anyway I don’t want to leave, because I thing they will have hard time without me, so I decided that I will only leave if I get a great offer.

]]> By: Abhishek http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-12 Abhishek Sun, 13 Jul 2008 14:58:44 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-12 @Emran, I actually like your question. It shows the other aspect of the very same problem. On that question, I would say that I am motivated by good supportive words. In that regard my manager is indeed very helpful. I do get constructive criticism and he highlights my areas of improvement which is very helpful. I believe that good words amalgamated with a proper amount of direction does work. At least in my case it does. IMO that is the art of management and managers should be picky of their words and careful of their approach. I have seen people working harder if ample amount of motivation is given. In our company we have the practice of giving "Spot" awards which actually is meant for acknowledgment of the good work done by the individual and also motivate others. Many other enterprises have similar approaches. Team outings and recreational activities are also good ways to release the stress and get the team in action. Thanks for putting light on this aspect of the issue. @Michael, I totally agree with you. Being in a senior position not only gives you a responsibility to write good code which reflects your experience and maturity but it also gives you an opportunity to motivate your juniors. As I said, good coding is not just an effort but it is also a practice. If you deliberately delve into writing something stupid then that will actually hamper your own skills, credibility and respect in long run. @Emran, I actually like your question. It shows the other aspect of the very same problem. On that question, I would say that I am motivated by good supportive words. In that regard my manager is indeed very helpful. I do get constructive criticism and he highlights my areas of improvement which is very helpful. I believe that good words amalgamated with a proper amount of direction does work. At least in my case it does. IMO that is the art of management and managers should be picky of their words and careful of their approach. I have seen people working harder if ample amount of motivation is given. In our company we have the practice of giving “Spot” awards which actually is meant for acknowledgment of the good work done by the individual and also motivate others. Many other enterprises have similar approaches. Team outings and recreational activities are also good ways to release the stress and get the team in action. Thanks for putting light on this aspect of the issue.

@Michael, I totally agree with you. Being in a senior position not only gives you a responsibility to write good code which reflects your experience and maturity but it also gives you an opportunity to motivate your juniors. As I said, good coding is not just an effort but it is also a practice. If you deliberately delve into writing something stupid then that will actually hamper your own skills, credibility and respect in long run.

]]> By: Michael Sharman http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-11 Michael Sharman Sun, 13 Jul 2008 11:30:50 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-11 I've worked with developers who write messy code, some if it at a high standard and some not, but often quite unreadable and certainly hard to maintain. I'm sure a lack of time can be mentioned as the cause, but I don't quite understand why senior developers write that way straight off the bat. Don't you automatically indent your code and comment where you need to? In terms of a poor solution? Well that is also disturbing, why even go down the path of a bad solution if you know it won't scale or will be a nightmare to maintain? If you can't speak with a development manager (or at least someone in management) about this to get more time, might be time to start looking elsewhere for employment. If you're not happy at work, chances are you won't be happy in life. I’ve worked with developers who write messy code, some if it at a high standard and some not, but often quite unreadable and certainly hard to maintain.

I’m sure a lack of time can be mentioned as the cause, but I don’t quite understand why senior developers write that way straight off the bat. Don’t you automatically indent your code and comment where you need to?

In terms of a poor solution? Well that is also disturbing, why even go down the path of a bad solution if you know it won’t scale or will be a nightmare to maintain? If you can’t speak with a development manager (or at least someone in management) about this to get more time, might be time to start looking elsewhere for employment.

If you’re not happy at work, chances are you won’t be happy in life.

]]> By: Md Emran Hasan http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-10 Md Emran Hasan Sun, 13 Jul 2008 05:13:34 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-10 Well, this type of nonprofessional attitude are very disturbing for the management as well as the team lead. And more disturbing is when the employees are "thinking" that they are overstressed rather in reality. Some of them do not have the habit of working effectively for more than a few hrs and when they are pushed to increase their effectiveness, they think its overstress. The management expects to have around 4-6 hrs of effective work output from a developer's 8 hr office time - but if they are not ready to provide that, there remains very few ways to push them. From your experience, what do you think is the best way to handle this kind of situation ? Well, this type of nonprofessional attitude are very disturbing for the management as well as the team lead. And more disturbing is when the employees are “thinking” that they are overstressed rather in reality. Some of them do not have the habit of working effectively for more than a few hrs and when they are pushed to increase their effectiveness, they think its overstress. The management expects to have around 4-6 hrs of effective work output from a developer’s 8 hr office time - but if they are not ready to provide that, there remains very few ways to push them.

From your experience, what do you think is the best way to handle this kind of situation ?

]]> By: Jason http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-9 Jason Sun, 13 Jul 2008 03:55:39 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-9 I agree to Abhishek. I have seen some guys doing the same in my office as well. I will forward this link to them :) Thanks I agree to Abhishek. I have seen some guys doing the same in my office as well. I will forward this link to them :)
Thanks

]]> By: Abhishek http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-8 Abhishek Sun, 13 Jul 2008 03:19:38 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-8 Thanks for your replies. @Matt, I didn't use any wordprocessor for writing this article. It was written all in one go in Scribefire which doesn't provide grammatical or lexical checking. Also, English is not my first language but I would like to improve on that. Thanks for your comments. @Tristan, neither I was nooby nor that piece of code was written one year back. Though, I agree to the point that the guy may not be good enough in TSQL. But as I have always followed the rule of thumb that "<i>Not knowing is not bad, rather not having the ability or willingness to learn is more futile</i>". Hence, that was something that was more disturbing. Thanks for your replies.

@Matt, I didn’t use any wordprocessor for writing this article. It was written all in one go in Scribefire which doesn’t provide grammatical or lexical checking. Also, English is not my first language but I would like to improve on that. Thanks for your comments.

@Tristan, neither I was nooby nor that piece of code was written one year back. Though, I agree to the point that the guy may not be good enough in TSQL. But as I have always followed the rule of thumb that “Not knowing is not bad, rather not having the ability or willingness to learn is more futile“. Hence, that was something that was more disturbing.

]]> By: elPadawan http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-7 elPadawan Sun, 13 Jul 2008 01:35:09 +0000 http://abhi.dcmembers.com/blog/2008/07/12/reasons-to-write-bad-code/#comment-7 @Keith: "I think no organization would force its employee beyond his limits." <-- unfortunately, some do. They work their employees to the core until they either leave, or breakdown and don't come back from long-term sick leave... @Keith: “I think no organization would force its employee beyond his limits.” <– unfortunately, some do. They work their employees to the core until they either leave, or breakdown and don’t come back from long-term sick leave…

]]>